Add GPT-5 model support and temperature documentation #4068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPT-5 models (gpt-5, gpt-5-2025-08-07) only support temperature=1.0 and will error with other values. This change adds a parameterized test to validate both models work correctly and updates documentation to warn users about this temperature requirement. - Add chatCompletionEntityWithNewModels test in OpenAiApiIT - Set temperature to 1.0 for GPT-5 compatibility - Add NOTE section in openai-chat.adoc about temperature restriction
- Add GPT_5 and GPT_5_2025_08_07 enum constants to ChatModel in OpenAiApi.java - Update OpenAiApiIT test to use enum constants instead of hardcoded strings - Enhance README.md to highlight support for latest models including GPT-5 - Include JavaDoc documentation with temperature requirement notes (1.0) Fixes GPT-5 model integration with proper type-safe enum constants
|
Merged via 1a3ed95. |
sobychacko
pushed a commit
that referenced
this pull request
Aug 7, 2025
Fixes #4068 - Add GPT_5 and GPT_5_2025_08_07 enum constants to ChatModel in OpenAiApi.java - Update OpenAiApiIT test to use enum constants instead of hardcoded strings - Enhance README.md to highlight support for latest models including GPT-5 - Include JavaDoc documentation with temperature requirement notes (1.0) Add GPT-5 model support and temperature documentation GPT-5 models (gpt-5, gpt-5-2025-08-07) only support temperature=1.0 and will error with other values. This change adds a parameterized test to validate both models work correctly and updates documentation to warn users about this temperature requirement. - Add chatCompletionEntityWithNewModels test in OpenAiApiIT - Set temperature to 1.0 for GPT-5 compatibility - Add NOTE section in openai-chat.adoc about temperature restriction Fixes GPT-5 model integration with proper type-safe enum constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for testing GPT-5 models and documents their temperature requirements.
Changes
Test Implementation
Documentation Update
Background
GPT-5 models have a strict temperature requirement and will return an error if any value other than 1.0 is used.
Testing
Related Issues
This change addresses model compatibility issues with the new GPT-5 models and improves user documentation to prevent configuration errors.